Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morphing a call activity to an expanded sub-process should add a start event #1631

Closed
Skaiir opened this issue Apr 7, 2022 · 1 comment · Fixed by #1636
Closed

Morphing a call activity to an expanded sub-process should add a start event #1631

Skaiir opened this issue Apr 7, 2022 · 1 comment · Fixed by #1636
Assignees
@smbea
Labels
bug Something isn't working modeling spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Apr 7, 2022

Describe the Bug

When morphing a call activity to a subprocess, it creates a tiny subprocess which looks just like a task, this is confusing UX wise and a first step to fix this would be for the morphing behavior to match that of tasks and include a start event.

image

Steps to Reproduce

  1. create a C7 BPMN diagram
  2. create a Task
  3. morph it to a call activity
  4. morph it to an expanded subprocess

Expected Behavior

Expanded sub process should be created with an event like it is done when morphing from a task:

image
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog spring cleaning Could be cleaned up one day labels Apr 7, 2022
@nikku nikku added the modeling label Apr 7, 2022
@Skaiir Skaiir mentioned this issue Apr 7, 2022
Closed
@smbea smbea self-assigned this Apr 21, 2022
@smbea smbea added the ready Ready to be worked on label Apr 21, 2022 — with bpmn-io-tasks
@smbea smbea removed the backlog Queued in backlog label Apr 21, 2022
@smbea
Copy link
Contributor

smbea commented Apr 21, 2022

I have some capacity so I will look into this one

smbea added a commit that referenced this issue Apr 21, 2022
@smbea
fix(bpmn-replace): add CallActivity to SubProcessStartEvent behaviour
5853b99 
Closes #1631
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Apr 21, 2022
@smbea smbea mentioned this issue Apr 21, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 21, 2022
smbea added a commit that referenced this issue Apr 21, 2022
@smbea
fix(bpmn-replace): add CallActivity to SubProcessStartEvent behaviour
d141f11 
Closes #1631
@fake-join fake-join bot closed this as completed in #1636 Apr 22, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 22, 2022
fake-join bot pushed a commit that referenced this issue Apr 22, 2022
@smbea @fake-join
fix(bpmn-replace): add CallActivity to SubProcessStartEvent behaviour
bdc3966 
Closes #1631
fake-join bot pushed a commit that referenced this issue May 13, 2022
@smbea @fake-join
fix(bpmn-replace): add CallActivity to SubProcessStartEvent behaviour
e07ab82 
Closes #1631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
bug Something isn't working modeling spring cleaning Could be cleaned up one day
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add StartEvent when morphing from CallActivity to expanded SubProcess bpmn-io/bpmn-js
3 participants
@nikku @Skaiir @smbea