Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space tool resizes empty pool vertically #1769

Closed
nikku opened this issue Nov 11, 2022 · 9 comments · Fixed by #1928
Closed

Space tool resizes empty pool vertically #1769

nikku opened this issue Nov 11, 2022 · 9 comments · Fixed by #1928
Labels
bug Something isn't working good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented Nov 11, 2022

Describe the Bug

An empty pool has a dedicated, fixed height shape to distinguish it from lanes / expanded pools. Using the space tool it gets resized however:

capture SiJdcQ_optimized

Steps to Reproduce

  1. Model an empty pool
  2. Use space tool on top of empty pool

(Can be reproduced on https://demo.bpmn.io/s/application-processing).

Expected Behavior

Empty pool does not resize (vertically).

Environment

@nikku nikku added bug Something isn't working modeling good first issue Good for newcomers spring cleaning Could be cleaned up one day labels Nov 11, 2022
@MaverickDe
Copy link

Hi, can I get assigned to this issue, Thanks

@nikku
Copy link
Member Author

nikku commented Nov 13, 2022

@MaverickDe If you're interested go ahead and file a PR.

@nikku nikku added the backlog Queued in backlog label Nov 14, 2022 — with bpmn-io-tasks
@jyzib
Copy link

jyzib commented Apr 18, 2023

Hi, can I get assigned to this issue, Thanks

@nikku
Copy link
Member Author

nikku commented Apr 18, 2023

@jyzib You don't need to be assigned. If you want to contribute, please open a PR that fixes this issue (or attempts a fix).

@hkupitz
Copy link
Contributor

hkupitz commented Jul 5, 2023

I have a fix ready for the space-tool behavior, but I wonder if it generally should be impossible to resize an empty pool vertically.

The bug description by @nikku says:

An empty pool has a dedicated, fixed height shape to distinguish it from lanes / expanded pools. Using the space tool it gets resized however:

Maybe I am misunderstanding this, but should the following be possible or not?

emptypool

@nikku
Copy link
Member Author

nikku commented Jul 6, 2023

@hkupitz That is an interesting question. I'd argue: A default size empty pool makes it simpler to recognize it and not confuse it with a lane. So 👍 from my side.

@nikku
Copy link
Member Author

nikku commented Jul 6, 2023

On the other hand making something not resizable is a bold move; we may not be aware of all scenarios, and we may not be ready for on-direction resizing either, nor won't be our users. I.e. I don't know this to be a thing from a drawing tool.

So let's decouple this fix from the general "should be resizable" discussion. In terms of resizing we are well covered; essentially we want empty pools to behave like text annotations; these do not resize either (in any direction):

capture 74IzGE_optimized

@hkupitz
Copy link
Contributor

hkupitz commented Jul 6, 2023

I think using the spacing tool along the x-axis should be allowed as empty pools quite often stretch along another accompanied pools:

spacetool_yaxis_disabled

When disabling both axes, this leads to - in my opinion - unexpected behavior:

spacetool_fully_disabled

What do you think, @nikku?

@nikku
Copy link
Member Author

nikku commented Jul 6, 2023

100% agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day
Development

Successfully merging a pull request may close this issue.

4 participants