Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-selection in viewer causes black boxes #2135

Open
nikku opened this issue Apr 10, 2024 · 6 comments
Open

Multi-selection in viewer causes black boxes #2135

nikku opened this issue Apr 10, 2024 · 6 comments
Labels
backlog Queued in backlog bug Something isn't working embedding good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented Apr 10, 2024

Describe the Bug

As a user I'm embedding the viewer as recommended in the starter project. When I select elements no outline is shown, I can still react to selected events; this I expect.

However when I select more than one element a black box appears that hides the diagram:

capture vSxTJn_optimized

Steps to Reproduce

  1. open starter viewer example
  2. select more than one element using SHIFT + click
  3. see black box appear

Expected Behavior

  • No black box appears
  • (Alternative) Selection is not available for the viewer

Environment

  • Browser: Chrome 110
  • OS: Linux
  • Library version: v14.0.0
@nikku nikku added bug Something isn't working embedding labels Apr 10, 2024
@nikku nikku mentioned this issue Apr 10, 2024
@philippfromme
Copy link
Contributor

philippfromme commented Apr 10, 2024

I think that we need to be clear on what a viewer is. The default viewer in my opinion, should behave like viewing an SVG. No interactivity at all. I never liked the fact that you get selection behavior in the viewer. Now, there are use cases that need an interactive viewer. In these cases, users need to include the required features and stylesheets as well. Alternatively, we could offer something similar to the navigated viewer.

@philippfromme
Copy link
Contributor

There would still remain the problem of interactive viewer and no selection outlines for connections. In the modeler selection is indicated by showing the bendpoints.

image

In an interactive viewer selecting connections should be indicated. We should have a solution for that.

@nikku
Copy link
Member Author

nikku commented Apr 10, 2024

No interactivity means that you cannot properly react to states in i.e. overlays. Hence the viewer would always offer basic interactivity, including hover and selection.

@philippfromme
Copy link
Contributor

Overlays is a feature of an interactive viewer, I'd say.

@barmac
Copy link
Member

barmac commented Apr 10, 2024

I'd say there are 4 ways to display diagram:

  • Modeler
  • NavigatedViewer
  • Viewer with some interactivity
  • Displaying result of Viewer.saveSVG

Otherwise we should rename the Viewer to Renderer, as that's what it is without any interactivity.

@nikku
Copy link
Member Author

nikku commented Apr 10, 2024

Thanks for #2135 (comment) @barmac. I subscribe to it. Without interactivity the viewer is simply a renderer.

You can roll your own barebones renderer if you so desire on top of the BaseViewer package.

@nikku nikku added good first issue Good for newcomers spring cleaning Could be cleaned up one day labels Apr 15, 2024
@nikku nikku added the backlog Queued in backlog label Apr 16, 2024 — with bpmn-io-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working embedding good first issue Good for newcomers spring cleaning Could be cleaned up one day
Development

No branches or pull requests

3 participants