Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if we want to use context-fill and context-stroke for rendering markers #2183

Closed
2 tasks
marstamm opened this issue May 30, 2024 · 2 comments
Closed
2 tasks
Assignees

Comments

@marstamm
Copy link
Contributor

What should we do?

Check if we can use context-fill and context-stroke for coloring markers. This is part of the SVG 2 standard, but browser support is not documented well.

  • Test common browsers for support
  • Decide if we want to remove local rendering of markers in favor of styling with the path

Why should we do it?

Can potentially simplify our rendering

related to camunda/camunda-modeler#4307, #2179

@marstamm marstamm self-assigned this May 30, 2024
@marstamm marstamm added the backlog Queued in backlog label May 30, 2024
@marstamm
Copy link
Contributor Author

I tested a simple demo to check which browser (and what version) supports this feature. I used browserstack for this.

  • Firefox: >=111 (Mar 2023)
  • Edge: >=124 (Apr 2024)
  • Chrome: >=124 (Apr 2024)
  • Opera: no support
  • Safari: no support
  • Electron: >=30 (Chrome 124)

We already build on Electron 30, so it would work in the desktop modeler.

While we officially only support browsers where we can use this feature, the overall support is limited and only adopted recently by chromium.

Let's not move on this now

@marstamm
Copy link
Contributor Author

marstamm commented Jun 3, 2024

As discussed in #2183 (comment), this is not feasible right now. We can revisit if the Browser support improves. Until then, we have a solid solution with individual marker rendering.

Closing as not planned (no refactoring issues).

@marstamm marstamm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant