Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message flow layout on participant resize #574

Closed
nikku opened this issue Jun 15, 2016 · 2 comments
Closed

Fix message flow layout on participant resize #574

nikku opened this issue Jun 15, 2016 · 2 comments
Assignees
Milestone

Comments

@nikku
Copy link
Member

nikku commented Jun 15, 2016

Existing message flows should not break/relayout on participant resize, unless their docking points got resized away.

Cf. forum thread.

Example Interaction

image

@nikku nikku added the bug Something isn't working label Jun 15, 2016
@nikku nikku added this to the Backlog milestone Jun 15, 2016
@martinschimak
Copy link

martinschimak commented Jun 15, 2016

Many thx for opening this issue.

  1. This is breaking on "move" actions, too.

  2. Let me add my personal point of view on the rules for the underlying algorithm. In my mind,

  • Message flow's source and target points connected to a flow symbol should always stick at the exact border point of the flow symbol at which they have been connected before. Move and Resize Actions should not change those points by default but prefer a cornered line to connect the points.

    (Reason: Typically I have a very good (readability) reason to connect a flow at a very specific position. When I move some objects, I would get a few cornered message flows, which would not be as harmful as changed connections points. Furthermore I can then decide to move/resize a communicating participant, too, which would typically give me straight message flows again, at least if I find the correct position for the flows.)

  • When moving participants, message flow's source and target points connected to this or other's participant's borders should float along the border as long as it is possible to re-connect the messages flow to the participant.

    (Reason: Here it typically does not matter at which point the message flow is connected, and in particular straight lines should remain straight. Therefore the message flows should "float" along the participant's border)

@martinschimak
Copy link

I updated my previous comment. Please reread, if you already have read it before. Thx.

@ricardomatias ricardomatias added interaction enhancement in progress Currently worked on and removed bug Something isn't working labels Jun 21, 2016
@ricardomatias ricardomatias self-assigned this Jun 21, 2016
ricardomatias pushed a commit to bpmn-io/diagram-js that referenced this issue Jun 21, 2016
@ricardomatias ricardomatias added needs review Review pending and removed in progress Currently worked on labels Jun 21, 2016
@ricardomatias ricardomatias assigned nikku and unassigned ricardomatias Jun 21, 2016
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Jun 21, 2016
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Jun 22, 2016
@nikku nikku closed this as completed in 6549af7 Jun 22, 2016
@nikku nikku removed the needs review Review pending label Jun 22, 2016
@nikku nikku modified the milestones: B17 - Next, Backlog Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants