Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels get lost during pool extraction #921

Closed
1 task
nikku opened this issue Dec 4, 2018 · 3 comments · Fixed by #1151
Closed
1 task

Labels get lost during pool extraction #921

nikku opened this issue Dec 4, 2018 · 3 comments · Fixed by #1151
Assignees
Labels
bug Something isn't working modeling
Milestone

Comments

@nikku
Copy link
Member

nikku commented Dec 4, 2018

Describe the Bug

Sometimes users would like to extract the participant contents into a process diagram. If you do that within a single diagram instance the labels get lost:

foo

Steps to Reproduce

  • Open example diagram
  • Copying the participant contents
  • Removing all diagram contents
  • Pasting the copied contents
  • Diagram is missing labels

Expected Behavior

  • Labels are pasted along with elements

Environment

Please complete the following information:

  • Browser: Any
  • OS: Any
  • Library version: v3.0.3

Additional Context

@ghost ghost assigned nikku Dec 4, 2018
@ghost ghost added the in progress Currently worked on label Dec 4, 2018
@nikku nikku removed their assignment Dec 4, 2018
@nikku nikku removed the in progress Currently worked on label Dec 4, 2018
@pinussilvestrus
Copy link
Contributor

I was able to reproduce this bug on demo.bpmn.io (latest bpmn-js v3.0.3).

@pinussilvestrus pinussilvestrus added bug Something isn't working modeling ready Ready to be worked on backlog Queued in backlog and removed ready Ready to be worked on labels Dec 4, 2018
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Aug 7, 2019
@nikku nikku removed the in progress Currently worked on label Aug 7, 2019
@nikku nikku added the ready Ready to be worked on label Aug 7, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M30 milestone Aug 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Aug 7, 2019
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Aug 7, 2019 — with bpmn-io-tasks
@philippfromme
Copy link
Contributor

philippfromme commented Aug 7, 2019

This is still an issue. Deleting labels unsets their label targets name. The label shape is still copied but won't be visible afterward since the label target has no name. Since we don't serialize business objects when copying we need to copy the name to the descriptor.

@nikku nikku added backlog Queued in backlog and removed needs review Review pending labels Aug 7, 2019
philippfromme added a commit that referenced this issue Aug 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Aug 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Aug 7, 2019
@nikku
Copy link
Member Author

nikku commented Aug 8, 2019

Closed via #1151.

@nikku nikku closed this as completed Aug 8, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 8, 2019
barmac pushed a commit that referenced this issue Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modeling
Development

Successfully merging a pull request may close this issue.

3 participants