Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequence flow ends do not crop after undo/redo #940

Closed
nikku opened this issue Feb 21, 2019 · 2 comments
Closed

Sequence flow ends do not crop after undo/redo #940

nikku opened this issue Feb 21, 2019 · 2 comments
Assignees
@barmac
Labels
bug Something isn't working
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Feb 21, 2019 •
edited
Loading

Describe the Bug

After deleting a task (A in the screencast below) and performing undo / redo the underlying sequence flow does not crop anymore, resulting in a broken layout:

screencapture

Steps to Reproduce

Steps to reproduce the behavior:

  • Open test diagram
  • Delete Task A
  • Undo
  • Redo
  • Sequence flow connecting start event and other task is not cropped on task / event border

Expected Behavior

  • Cropping works.

Environment

Please complete the following information:

  • Browser: Chrome
  • OS: Arch Linux
  • Library version: v3.2.1

Possible duplicate of #891

Depends on #891
@pinussilvestrus pinussilvestrus added bug Something isn't working backlog Queued in backlog labels Feb 21, 2019
@nikku nikku added this to the M29 milestone Mar 6, 2019
@nikku nikku mentioned this issue Mar 6, 2019
Closed
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 2, 2019
@barmac barmac self-assigned this Apr 2, 2019
@barmac barmac added in progress Currently worked on and removed ready Ready to be worked on labels Apr 2, 2019
@barmac
Copy link
Member

barmac commented Apr 8, 2019 •
edited
Loading

Findings:

I need to add a test case for proper layout with Manhattan.

@barmac barmac mentioned this issue Apr 9, 2019
Merged
barmac added a commit that referenced this issue Apr 9, 2019
@barmac
test(modeling): ensure layout is done after element removal
02511d2 
Closes #940
@barmac barmac mentioned this issue Apr 9, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Apr 9, 2019
barmac added a commit that referenced this issue Apr 9, 2019
@barmac
test(modeling): ensure layout is done after element removal
6046b35 
Closes #940
barmac added a commit that referenced this issue Apr 9, 2019
@barmac
test(modeling): ensure layout is done after element removal
d07a939 
    Closes #940
barmac added a commit that referenced this issue Apr 9, 2019
@barmac
test(modeling): ensure layout is done after element removal
1a84f8f 
Closes #940
nikku added a commit that referenced this issue Apr 9, 2019
@nikku
chore(project): bump diagram-js dependency
634504b 
Related to #940
nikku pushed a commit that referenced this issue Apr 9, 2019
@barmac @nikku
test(modeling): ensure layout is done after element removal
26ec0fa 
Closes #940
barmac added a commit that referenced this issue Apr 10, 2019
@barmac
test(modeling): ensure layout is done after element removal
cf90381 
Closes #940
barmac added a commit that referenced this issue Apr 10, 2019
@barmac
test(modeling): ensure layout is done after element removal
e72f19d 
Closes #940
barmac added a commit that referenced this issue Apr 10, 2019
@barmac
test(modeling): ensure layout is done after element removal
22529a2 
Closes #940
nikku pushed a commit that referenced this issue Apr 10, 2019
@barmac @nikku
chore(project): bump diagram-js
35591d0 
Closes #940
nikku pushed a commit that referenced this issue Apr 10, 2019
@barmac @nikku
chore(modeling/BpmnUpdater): remove now unnecessary crop on reconnect
040678e 
As of diagram-js@3.2.0 layouting will be triggered
on reconnectStart / reconnectEnd.

Related to #940
nikku pushed a commit that referenced this issue Apr 10, 2019
@barmac @nikku
test(modeling): ensure layout is done after element removal
59aa57a 
* adjust test suite to pass with diagram-js@3.2
* verify new cropping behavior
* verify #940 is fixed
merge-me bot pushed a commit that referenced this issue Apr 10, 2019
@barmac @merge-me
chore(project): bump diagram-js
bc586d0 
Closes #940
merge-me bot pushed a commit that referenced this issue Apr 10, 2019
@barmac @merge-me
chore(modeling/BpmnUpdater): remove now unnecessary crop on reconnect
6f79250 
As of diagram-js@3.2.0 layouting will be triggered
on reconnectStart / reconnectEnd.

Related to #940
merge-me bot pushed a commit that referenced this issue Apr 10, 2019
@barmac @merge-me
test(modeling): ensure layout is done after element removal
8eced8a 
* adjust test suite to pass with diagram-js@3.2
* verify new cropping behavior
* verify #940 is fixed
@nikku
Copy link
Member Author

nikku commented Apr 10, 2019

Closed via #971.

@nikku nikku closed this as completed Apr 10, 2019
@ghost ghost removed the needs review Review pending label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Milestone
M29
Development

No branches or pull requests
3 participants
@nikku @pinussilvestrus @barmac