Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(copy-paste): emit <moddleCopy.canSetCopiedProperty> with existing property #1283

Merged
merged 1 commit into from Mar 2, 2020
Merged

fix(copy-paste): emit <moddleCopy.canSetCopiedProperty> with existing property #1283

merged 1 commit into from Mar 2, 2020

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 2, 2020

parent was previously not defined.

The only reason it did not 💥 in most contexts is that there exists a global window.parent property that 🤕 things.

Related to bpmn-io/vs-code-bpmn-io#65

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 2, 2020
@nikku nikku changed the base branch from develop to master March 2, 2020 13:02
@fake-join fake-join bot merged commit 707257e into master Mar 2, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 2, 2020
@fake-join fake-join bot deleted the parent-stuff branch March 2, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikku @pinussilvestrus