Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bpmnRules): disallow boundaryEvents as message flow targets #1330

Merged
merged 1 commit into from Jun 23, 2020
Merged

fix(bpmnRules): disallow boundaryEvents as message flow targets #1330

merged 1 commit into from Jun 23, 2020

Conversation

MaxTru
Copy link
Contributor

@MaxTru MaxTru commented Jun 22, 2020

Which issue does this PR address?

Closes #1300

Acceptance Criteria

  • Corresponds to the concept: Connection to any boundary event as a message flow source or target should be forbidden by rules

Definition of Done

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 22, 2020
@MaxTru MaxTru force-pushed the 1300-disallow-boundary-events-as-target branch from f9e6539 to 9400c8d Compare June 22, 2020 14:34
@MaxTru MaxTru changed the base branch from develop to master June 23, 2020 13:46
philippfromme
philippfromme approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@philippfromme philippfromme merged commit 8bc29e7 into master Jun 23, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 23, 2020
@fake-join fake-join bot deleted the 1300-disallow-boundary-events-as-target branch June 23, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boundary events must not be message flow targets
2 participants
@MaxTru @philippfromme