2042 - enable connection tool for text annotation

[tkhadir]

🔗 linked to camunda modeler issue : camunda/camunda-modeler#2042
purpose : enable connection tool to text annotation
modified :

• BpmnRules.js to be able start link from annotation to other component
• ContextPafProvider.js to add connectTool in the menu in addition to the remove icon

[MaxTru]

Hi @tkhadir ,

thanks a lot for your contribution! 👏

Before continuing: could you please:

1. Add tests for the added feature (take a look at https://github.com/bpmn-io/bpmn-js/blob/develop/test/spec/features/rules/BpmnRulesSpec.js#L2258 and https://github.com/bpmn-io/bpmn-js/blob/develop/test/spec/features/context-pad/ContextPadProviderSpec.js)
2. Ensure that the commit messages adhere to our to the conventional commits guidelines

Thanks!

–––––––––––––
Context: https://github.com/bpmn-io/bpmn-js/blob/develop/.github/CONTRIBUTING.md

[tkhadir]

hello @MaxTru,

I have update tests files according to the recommandations, thank you very much for your feedback 😄

[MaxTru]

Thanks for adding the tests. I added some comments after reviewing.

[MaxTru]

There is a linting error in ContextPadProvider

/home/maxtru/Dokumente/10_modules/bpmn-io/bpmn-js/lib/features/context-pad/ContextPadProvider.js
  446:1  error  Parsing error: Unexpected token

  444 | 
  445 |   return actions;
> 446 | };
      | ^
  447 | 
  448 | 
  449 | // helpers /////////

[tkhadir]

hello @MaxTru it seems good now 😄 thanks again for your feedback

[MaxTru]

Thanks a lot for the contribution, good job!

I squashed the commits together so to have a clean commit history: for the next time, please also try to only provide a handful (or even just one) reasonable commit, this makes it easier to review the change.

[tkhadir]

thanks lot @MaxTru for your great help 😄