Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ES2018 syntax #1737

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Use ES2018 syntax #1737

merged 4 commits into from
Sep 20, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Sep 8, 2022 •
edited

Breaking Changes

Requires bpmn-io/bpmn.io#147

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 8, 2022
@barmac barmac marked this pull request as ready for review September 12, 2022 14:16
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 12, 2022
@barmac barmac requested review from a team, pinussilvestrus and smbea and removed request for a team September 12, 2022 14:17
@pinussilvestrus
Copy link
Contributor

Should we integrate bpmn-io/eslint-plugin-bpmn-io#15 already with this PR as well?

@barmac
Copy link
Member Author

barmac commented Sep 13, 2022

I can add this.

@barmac barmac marked this pull request as draft September 13, 2022 13:45
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 13, 2022
@barmac barmac marked this pull request as ready for review September 14, 2022 07:24
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 14, 2022
@barmac
Copy link
Member Author

barmac commented Sep 14, 2022

Should we integrate bpmn-io/eslint-plugin-bpmn-io#15 already with this PR as well?

Done, and I also fixed one ESNext case ^^

@barmac barmac requested a review from nikku September 15, 2022 07:48
nikku
nikku requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@nikku nikku left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us unbuild the partial prototype -> class migration for the moment as discussed and consider a holistic upgrade (i.e. via codemod) at some point.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 19, 2022
@barmac barmac requested a review from nikku September 20, 2022 07:47
@barmac
Copy link
Member Author

barmac commented Sep 20, 2022

Modelers & Modeling migrations are now removed since they were mostly about class.

@barmac
Copy link
Member Author

barmac commented Sep 20, 2022

Ready for another round.

@fake-join fake-join bot merged commit 0a81b99 into develop Sep 20, 2022
@fake-join fake-join bot deleted the modern-syntax branch September 20, 2022 09:29
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus pinussilvestrus was automatically assigned from bpmn-io/modeling-dev

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from bpmn-io/modeling-dev

Assignees

@barmac barmac

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barmac @pinussilvestrus @nikku