Integrate new popup menu #1776
Merged
Integrate new popup menu #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
in progress
nikku
reviewed
Nov 17, 2022
nikku
reviewed
Nov 17, 2022
smbea
force-pushed
the
1775-integrate-new-popup-menu
branch
from
2253392
to
2d89383
Compare
|
I will now focus on releasing |
smbea
force-pushed
the
1775-integrate-new-popup-menu
branch
from
2d89383
to
83abcbe
Compare
bpmn-io-tasks
bot
added
needs review
smbea
requested review from
a team,
philippfromme,
barmac and
nikku
and removed request for
a team
|
Ready for a final look |
1 task
|
@nikku Could you have another look at this? |
|
I am looking into this right now. |
Screen.Recording.2022-11-21.at.09.56.30.movArrow keys don't work in the menu. Is this expected? |
Screen.Recording.2022-11-21.at.09.58.51.movSecond click on the input closes popup menu though it shouldn't. |
|
I created these 2 issues: bpmn-io/diagram-js#701, bpmn-io/diagram-js#702. |
|
What @barmac reported earlier (mouse vanished, still no keyboard selection) looks like a bug, not a browser quirk 🙈. Fixed behavior showcased here:
|
|
Some work in progress fixing issues is pushed at bpmn-io/diagram-js#706. |
smbea
force-pushed
the
1775-integrate-new-popup-menu
branch
from
83abcbe
to
26fae7e
Compare
nikku
force-pushed
the
1775-integrate-new-popup-menu
branch
from
26fae7e
to
05c97b8
Compare
|
Adjusted topic on these commits. |
nikku
reviewed
Nov 24, 2022
smbea
force-pushed
the
1775-integrate-new-popup-menu
branch
from
37d1113
to
e0230ca
Compare
|
I think it was missing adjustments here (following the popup menu being pulled out of the canvas). Could you check with my last commit? |
barmac
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1775
This is targetingdiagram-js@developsince this bug fix was added after the alpha release. My idea is to pre-approve this to make sure the new popup menu is working as expected so we can have the stable release ofdiagram-js, and later integrate it here.Integrate
diagram-js@11.0.0diagram-js@11.1.0Following the title discussion in the issue, I decided not to add the align title for now.