-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'replace element' keyboard binding #1785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smbea
requested review from
nikku,
a team and
marstamm
and removed request for
a team
December 5, 2022 08:28
nikku
requested changes
Dec 5, 2022
bpmn-io-tasks
bot
added
in progress
Currently worked on
and removed
needs review
Review pending
labels
Dec 5, 2022
smbea
force-pushed
the
1782-replace-keyboard-binding
branch
2 times, most recently
from
December 5, 2022 09:43
4272667
to
e2f03d7
Compare
smbea
force-pushed
the
1782-replace-keyboard-binding
branch
from
December 5, 2022 10:01
e2f03d7
to
b9567c8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
smbea
force-pushed
the
1782-replace-keyboard-binding
branch
from
December 7, 2022 19:19
b9567c8
to
67fc16f
Compare
smbea
force-pushed
the
1782-replace-keyboard-binding
branch
from
December 7, 2022 19:41
67fc16f
to
29f0798
Compare
smbea
commented
Dec 7, 2022
smbea
force-pushed
the
1782-replace-keyboard-binding
branch
from
December 9, 2022 13:42
29f0798
to
e05c677
Compare
nikku
force-pushed
the
1782-replace-keyboard-binding
branch
from
December 12, 2022 22:28
e05c677
to
a12fe92
Compare
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Dec 12, 2022
nikku
force-pushed
the
1782-replace-keyboard-binding
branch
from
December 12, 2022 22:29
a12fe92
to
ad42c25
Compare
nikku
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we arrived at a really good solution. ➕ path is clear for other keyboard only, context pad supported journeys. 🎉
Good job 🎖️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1782
Depends on bpmn-io/diagram-js#719