Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'replace element' keyboard binding #1785

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Dec 5, 2022

Closes #1782
Depends on bpmn-io/diagram-js#719

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 5, 2022
@smbea smbea requested review from nikku, a team and marstamm and removed request for a team December 5, 2022 08:28
lib/features/editor-actions/BpmnEditorActions.js Outdated Show resolved Hide resolved
lib/features/editor-actions/BpmnEditorActions.js Outdated Show resolved Hide resolved
lib/features/editor-actions/BpmnEditorActions.js Outdated Show resolved Hide resolved
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Dec 5, 2022
@smbea smbea force-pushed the 1782-replace-keyboard-binding branch 2 times, most recently from 4272667 to e2f03d7 Compare December 5, 2022 09:43
@smbea smbea requested a review from nikku December 5, 2022 09:46
@smbea smbea force-pushed the 1782-replace-keyboard-binding branch from e2f03d7 to b9567c8 Compare December 5, 2022 10:01
@nikku

This comment was marked as outdated.

@smbea smbea marked this pull request as draft December 7, 2022 19:46
@smbea smbea force-pushed the 1782-replace-keyboard-binding branch from 29f0798 to e05c677 Compare December 9, 2022 13:42
@nikku nikku force-pushed the 1782-replace-keyboard-binding branch from e05c677 to a12fe92 Compare December 12, 2022 22:28
@nikku nikku marked this pull request as ready for review December 12, 2022 22:28
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 12, 2022
@nikku nikku force-pushed the 1782-replace-keyboard-binding branch from a12fe92 to ad42c25 Compare December 12, 2022 22:29
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we arrived at a really good solution. ➕ path is clear for other keyboard only, context pad supported journeys. 🎉

Good job 🎖️

@nikku nikku merged commit dd3d9da into develop Dec 12, 2022
@nikku nikku deleted the 1782-replace-keyboard-binding branch December 12, 2022 22:47
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add keyboard shortcut for replace
2 participants