Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(element-factory): add missing attributes #1807

Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix(element-factory): add missing attributes #1807

merged 1 commit into from
Jan 18, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Jan 18, 2023

Came up in the context of #1802

  • Event subprocesses were being created as normal subprocesses
  • Non interrupting boundary events were being created as interrupting events

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 18, 2023
@smbea smbea mentioned this pull request Jan 18, 2023
Merged
@smbea smbea requested review from a team, philippfromme and barmac and removed request for a team January 18, 2023 09:25
nikku
nikku approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@smbea smbea merged commit 39dd936 into develop Jan 18, 2023
@smbea smbea deleted the element-factory-missing-attributes branch January 18, 2023 09:40
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 18, 2023
@smbea smbea mentioned this pull request Jan 18, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@barmac barmac Awaiting requested review from barmac barmac was automatically assigned from bpmn-io/modeling-dev

Assignees

@smbea smbea

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smbea @nikku