Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle missing BPMNDiagram#plane in legacy sub-process behavior #2172

Merged
merged 2 commits into from
May 27, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented May 27, 2024

Previously we'd scroll through all diagrams, assuming plane would always be set.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 27, 2024
@nikku nikku requested a review from marstamm May 27, 2024 09:37
@nikku nikku requested a review from philippfromme May 27, 2024 09:37
Base automatically changed from import-no-di-plane to develop May 27, 2024 09:45
@nikku nikku force-pushed the fix-drilldown-no-di-plane branch from e395f5e to 931b33c Compare May 27, 2024 09:45
Co-authored-by: Martin Stamm <martin.stamm@camunda.com>
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️

@nikku nikku merged commit a66d850 into develop May 27, 2024
12 checks passed
@nikku nikku deleted the fix-drilldown-no-di-plane branch May 27, 2024 11:17
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants