Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Update Element Template Feature broken #165

Closed
Tracked by #109
MaxTru opened this issue Nov 9, 2021 · 1 comment · Fixed by #170
Closed
Tracked by #109

Update Element Template Feature broken #165

MaxTru opened this issue Nov 9, 2021 · 1 comment · Fixed by #170
Assignees
Labels
bug Something isn't working element templates

Comments

@MaxTru
Copy link
Contributor

MaxTru commented Nov 9, 2021

Describe the Bug

Update Element Template Feature broken

Steps to Reproduce

ETBug

  1. Have multiple templates from Cawemo synced
  2. Apply one template
  3. => note that even though the template does not have a newer version, one can apply a new version. => the actual template is changed

(It seems the update logic does not filter on template id?)

Expected Behavior

Update element template logic only available for template with the same ID (and multiple versions)

Environment

#161

@MaxTru MaxTru added bug Something isn't working element templates labels Nov 9, 2021
This was referenced Nov 9, 2021
@barmac
Copy link
Member

barmac commented Nov 10, 2021

It seems that we'd need to re-render the templates group whenever templates are changed.

Indeed we don't check the template ID o.O

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working element templates
Development

Successfully merging a pull request may close this issue.

2 participants