Skip to content

Commit

Permalink
fix(lib): remove tx boundary from event based gateway
Browse files Browse the repository at this point in the history
  • Loading branch information
falko authored and Niklas Kiefer committed Nov 26, 2019
1 parent c73be78 commit 11e4179
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/TransactionBoundaries.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ TransactionBoundaries.prototype._getTransactionBoundaries = function(element) {
var isWaitStateTask = element.type === 'bpmn:ReceiveTask' || element.type === 'bpmn:UserTask'
|| (element.type === 'bpmn:ServiceTask' && businessObject.type === 'external');

var isWaitStateGateway = element.type === 'bpmn:EventBasedGateway';
var isWaitStateGateway = false; // TODO: Parallel/Inclusive Gateway with multiple incoming sequence flows

var isWaitStateEvent = element.type === 'bpmn:IntermediateCatchEvent' && (
eventDefinitionType === 'bpmn:MessageEventDefinition' ||
Expand Down
10 changes: 5 additions & 5 deletions test/spec/TransactionBoundariesSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('transaction-boundaries', function() {
transactionBoundaries.show();

// then
expect(overlays.get({ type: 'transaction-boundaries' })).to.have.length(9);
expect(overlays.get({ type: 'transaction-boundaries' })).to.have.length(8);

}));

Expand All @@ -75,7 +75,7 @@ describe('transaction-boundaries', function() {
transactionBoundaries.toggle();

// then
expect(overlays.get({ type: 'transaction-boundaries' })).to.have.length(9);
expect(overlays.get({ type: 'transaction-boundaries' })).to.have.length(8);

}));

Expand Down Expand Up @@ -118,7 +118,7 @@ describe('transaction-boundaries', function() {
var expectedBoundaries = {
'Task_1': { before: true, after: false },
'Task_2': { before: true, after: false },
'Gateway_2': { before: true, after: false },
'Gateway_2': { before: false, after: false },
'MessageCatchEvent': { before: true, after: false },
'Task_3': { before: true, after: false },
'Task_4': { before: false, after: true },
Expand All @@ -131,7 +131,7 @@ describe('transaction-boundaries', function() {
var transactionBoundaryElements = transactionBoundaries._getTransactionBoundaryElements();

// then
expect(transactionBoundaryElements).to.have.length(9);
expect(transactionBoundaryElements).to.have.length(8);

forEach(transactionBoundaryElements, function(element) {

Expand All @@ -144,4 +144,4 @@ describe('transaction-boundaries', function() {

});

});
});

0 comments on commit 11e4179

Please sign in to comment.