fix css toggle-button ignores title translation #44
Conversation
Unfortunately, the current implementation ignores translations and the buttons texts are hardcoded inside the css. The easiest fix is to use the title attribute of the parent div that is already translated.
|
|
nikku
requested review from
a team,
philippfromme and
barmac
and removed request for
a team
|
Thanks for your contribution. I will have a look. 👍 |
|
I like the solution and left just one small suggestion about code readability. Thanks for you contribution! :) |
| width: 46px; | ||
| height: 46px; | ||
| line-height: 46px; | ||
| padding: 10px; |
There was a problem hiding this comment.
This is not related to the translation issue, right?
There was a problem hiding this comment.
Yes it is. Fixed width does not work, otherwise you end up with an overflowing box and/or weird spacing. I replaced the line-height/height with padding for simplicity.
If you want to maintain the 46px height, just keep the line-height/height and only set padding to left/right.
There was a problem hiding this comment.
All right. So we should never have had fixed width here.
Co-authored-by: Maciej Barelkowski <maciejbarel@gmail.com>
|
I will be happy to merge this today, if you could only squash the changes and adjust the commit message to our contributing guidlines. Thanks! |
Already merged. Have a look at 038bb3c if you want to check what I meant :) And thanks for your contribution! |
|
Thx @barmac ❤️ |
|
Released in v2.0.4 :) |
Unfortunately, the current implementation ignores translations and the buttons texts are hardcoded inside the css.
The easiest fix is to use the title attribute of the parent div that is already translated.
Which issue does this PR address?
Closes #43