Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas scrolling not prevented inside popup menu #729

Closed
nikku opened this issue Jan 6, 2023 · 0 comments · Fixed by #730
Closed

Canvas scrolling not prevented inside popup menu #729

nikku opened this issue Jan 6, 2023 · 0 comments · Fixed by #730
Assignees
@nikku
Labels
bug Something isn't working

Comments

@nikku
Copy link
Member

nikku commented Jan 6, 2023 •
edited

Describe the Bug

With #728 we broke the ability to scroll within a popup menu:

capture J9U6WU_optimized

Steps to Reproduce

  • Open popup menu with decent size.
  • Try scroll.
  • Canvas scrolls

Expected Behavior

Scrolling happens inside popup menu.

Environment

Please complete the following information:

  • Browser: any
  • OS: any
  • Library version: 11.4.2+
@nikku nikku added the bug Something isn't working label Jan 6, 2023
@nikku nikku self-assigned this Jan 6, 2023
@nikku nikku added the ready Ready to be worked on label Jan 6, 2023
nikku added a commit that referenced this issue Jan 6, 2023
@nikku
fix: prevent canvas scrolling inside popup menu
3d04b74 
This ensures the popup menu is not accidentally canvas scrolled on mouse wheel.

Closes #729
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jan 6, 2023
@nikku nikku mentioned this issue Jan 6, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 6, 2023
nikku added a commit that referenced this issue Jan 6, 2023
@nikku
fix(popup-menu): prevent canvas scrolling inside popup menu
a438b09 
This ensures the popup menu is not accidentally canvas scrolled on mouse wheel.

Closes #729
@nikku nikku closed this as completed in #730 Jan 6, 2023
nikku added a commit that referenced this issue Jan 6, 2023
@nikku
fix(popup-menu): prevent canvas scrolling inside popup menu
df0238a 
This ensures the popup menu is not accidentally canvas scrolled on mouse wheel.

Closes #729
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent canvas scrolling inside popup menu bpmn-io/diagram-js
1 participant
@nikku