Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit popupMenu/palette/contextPad trigger events #771

Closed
smbea opened this issue Apr 4, 2023 · 0 comments · Fixed by #772
Closed

Emit popupMenu/palette/contextPad trigger events #771

smbea opened this issue Apr 4, 2023 · 0 comments · Fixed by #772
Assignees
@smbea

Comments

@smbea
Copy link
Contributor

smbea commented Apr 4, 2023

What should we do?

We should fire eventBus events when popup menu, palette or context pad actions are triggered.

  • popupMenu.trigger
  • palette.trigger
  • contextPad.trigger

Why should we do it?

This will facilitate tracking, see https://github.com/bpmn-io/internal-docs/issues/746#issuecomment-1495885885
@smbea smbea added the ready Ready to be worked on label Apr 4, 2023
@smbea smbea self-assigned this Apr 4, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Apr 5, 2023
@smbea smbea mentioned this issue Apr 5, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Apr 5, 2023
@smbea smbea closed this as completed in #772 Apr 5, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Apr 5, 2023
@smbea smbea mentioned this issue Apr 26, 2023
Closed
@smbea smbea mentioned this issue May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit popupMenu/palette/contextPad.trigger events bpmn-io/diagram-js
1 participant
@smbea