Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit popupMenu/palette/contextPad.trigger events #772

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Emit popupMenu/palette/contextPad.trigger events #772

merged 3 commits into from
Apr 5, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Apr 5, 2023 •
edited
Loading

Closes #771

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Apr 5, 2023
@smbea smbea marked this pull request as ready for review April 5, 2023 08:41
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 5, 2023
@smbea smbea requested review from nikku, a team and philippfromme and removed request for a team April 5, 2023 08:42
nikku
nikku requested changes Apr 5, 2023
View reviewed changes
lib/features/context-pad/ContextPad.js Outdated Show resolved Hide resolved
test/spec/features/context-pad/ContextPadSpec.js Outdated Show resolved Hide resolved
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Apr 5, 2023
@smbea smbea requested a review from nikku April 5, 2023 11:38
@smbea smbea added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Apr 5, 2023
@smbea smbea merged commit f990c16 into develop Apr 5, 2023
@smbea smbea deleted the 771-fire-trigger-events branch April 5, 2023 13:52
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Apr 5, 2023
@smbea smbea mentioned this pull request Apr 11, 2023
Merged
@smbea smbea mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit popupMenu/palette/contextPad trigger events
2 participants
@smbea @nikku