Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand and Selection Clashing When Handling CTRL Modifier #849

Closed
philippfromme opened this issue Jan 22, 2024 · 0 comments · Fixed by #850
Closed

Hand and Selection Clashing When Handling CTRL Modifier #849

philippfromme opened this issue Jan 22, 2024 · 0 comments · Fixed by #850
Assignees
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Jan 22, 2024

Describe the Bug

Both the hand tool and the selection feature handle Click + CTRL. The hand tool is activated while the selection adds an element to the selection (which is also possible through Click +SHIFT). Since both handle the same event and the hand tool handles the event first, adding to the selection doesn't work.

As seen in the following recording, Click + CTRL activates the hand tool:

brave_ZnyuAZbH8B

Steps to Reproduce

  1. Click + CTRL to try and add an element to the selection
  2. Nothing happens

Expected Behavior

Click + CTRL either works or we remove it.

Environment

  • Library version: 13.4.0
@philippfromme philippfromme added the bug Something isn't working label Jan 22, 2024
@philippfromme philippfromme reopened this Jan 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 22, 2024
nikku pushed a commit that referenced this issue Jan 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 22, 2024
@philippfromme philippfromme added the spring cleaning Could be cleaned up one day label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Development

Successfully merging a pull request may close this issue.

1 participant