feat(i18n): escape translations per default #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Jun 13, 2019
barmac
force-pushed
the
escape-translations-per-default
branch
from
e3c402d
to
1e453b9
Compare
nikku
approved these changes
Jun 13, 2019
|
Seems like I merged this one prematurely. Escaping translations breaks the library and tools building upon it: bpmn-io/bpmn-js#1080. Let's discuss and revise this next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that we escape translations per default to avoid XSS issues with i18n. Pass
safe=trueif the input is already safe.