Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom selection outlines #817

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Allow custom selection outlines #817

merged 2 commits into from
Oct 30, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Oct 25, 2023 •
edited

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 25, 2023
@smbea smbea force-pushed the allow-custom-selection-outlines branch from a58d91c to d6cd1c1 Compare October 26, 2023 12:37
@smbea smbea force-pushed the allow-custom-selection-outlines branch from d6cd1c1 to 5e165f1 Compare October 26, 2023 12:38
@smbea smbea marked this pull request as ready for review October 26, 2023 13:14
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 26, 2023
@smbea smbea force-pushed the allow-custom-selection-outlines branch from 5e165f1 to e2c5e1f Compare October 26, 2023 13:20
@smbea smbea requested review from a team, philippfromme and marstamm and removed request for a team October 26, 2023 13:29
philippfromme
philippfromme reviewed Oct 30, 2023
View reviewed changes
lib/features/outline/Outline.js Outdated Show resolved Hide resolved
lib/features/outline/Outline.js Outdated Show resolved Hide resolved
@smbea smbea marked this pull request as draft October 30, 2023 09:41
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 30, 2023
@smbea smbea force-pushed the allow-custom-selection-outlines branch from e2c5e1f to 7795cb0 Compare October 30, 2023 12:20
@smbea smbea marked this pull request as ready for review October 30, 2023 12:33
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 30, 2023
philippfromme
philippfromme approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a couple of code formatting issues and typos. Good job! 🚀

@philippfromme philippfromme merged commit 2b01eca into develop Oct 30, 2023
12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 30, 2023
@philippfromme philippfromme deleted the allow-custom-selection-outlines branch October 30, 2023 15:01
@nikku nikku mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@marstamm marstamm Awaiting requested review from marstamm marstamm was automatically assigned from bpmn-io/modeling-dev

Assignees

@smbea smbea

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smbea @philippfromme