feat(preview-support): add copied marker as part of djs-visual #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
nikku
reviewed
May 28, 2024
| }; | ||
| // Markers are cleaned up with visuals, keep stub for compatibility | ||
| // cf. https://github.com/camunda/camunda-modeler/issues/4307 | ||
| PreviewSupport.prototype.cleanUp = function() {}; |
There was a problem hiding this comment.
We could consider to log a warning here that this is no longer being used (and will be removed in future major releases).
Cf. ContextPad.getPad or other instances.
nikku
reviewed
May 28, 2024
| @@ -204,12 +190,12 @@ PreviewSupport.prototype._cloneMarker = function(gfx, marker, markerType, classN | |||
|
|
|||
| this._clonedMarkers[ markerId ] = clonedMarker; | |||
|
|
|||
| var defs = domQuery('defs', this._canvas._svg); | |||
| var defs = domQuery(':scope > defs', parentGfx); | |||
There was a problem hiding this comment.
What is the support for :scope within CSS?
There was a problem hiding this comment.
Everything except IE11
nikku
reviewed
May 28, 2024
|
I tested it and it looks good to me as well. |
|
Added deprecation warning with 0f12ab6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
defsections in the svgcloses #904
Test it out with
downstream draft PR: bpmn-io/bpmn-js#2173