Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate marker ids in preview #909

Merged
merged 3 commits into from
May 29, 2024
Merged

Prevent duplicate marker ids in preview #909

merged 3 commits into from
May 29, 2024

Conversation

marstamm
Copy link
Contributor

This PR:

  • changes the marker ID if it was part of the djs-visual instead of creating a new one.
  • Adds a random string to the copied marker ID. This ensures we do not have overlaps if the same connection is present multiple times in a preview. While this should not happen, it did happen in the past so better be safe here.
  • Ensures we copy connections only once in move preview

related to bpmn-io/bpmn-js#2179

@marstamm marstamm requested a review from a team May 29, 2024 09:36
@marstamm marstamm self-assigned this May 29, 2024
@marstamm marstamm requested review from philippfromme and barmac and removed request for a team May 29, 2024 09:36
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 29, 2024
@marstamm marstamm force-pushed the prevent-duplicate-marker-ids branch 2 times, most recently from 25f7dbb to 525c178 Compare May 29, 2024 12:10
@nikku nikku force-pushed the prevent-duplicate-marker-ids branch from 525c178 to 9798f8b Compare May 29, 2024 12:47
nikku
nikku approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and could not break it. Good job 👏

@marstamm marstamm merged commit 95c7908 into develop May 29, 2024
10 checks passed
@marstamm marstamm deleted the prevent-duplicate-marker-ids branch May 29, 2024 12:54
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 29, 2024
@nikku nikku mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@barmac barmac Awaiting requested review from barmac barmac was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marstamm @nikku