Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make name field a text area #95

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

jarekdanielak
Copy link
Contributor

Closes #94

Make "Name" field a text area instead of an input to support multiple lines of text.

image

@jarekdanielak jarekdanielak requested review from barmac and a team July 2, 2024 09:31
@jarekdanielak jarekdanielak self-assigned this Jul 2, 2024
@jarekdanielak jarekdanielak requested review from philippfromme and removed request for a team July 2, 2024 09:31
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 2, 2024
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is OK but perhaps we could do better. Note that we immediately experience the problem reported for the documentation: camunda/camunda-modeler#3660

Screen.Recording.2024-07-02.at.13.55.29.mov

So I'd suggest to add autoresizing to this PR already.

@jarekdanielak jarekdanielak merged commit e9eaa06 into main Jul 3, 2024
8 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 3, 2024
@jarekdanielak jarekdanielak deleted the 94-make-name-field-text-area branch July 3, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make "name" field a text area
2 participants