Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot tab into the decision table header #845

Closed
barmac opened this issue Apr 5, 2024 · 1 comment · Fixed by #883
Closed

Cannot tab into the decision table header #845

barmac opened this issue Apr 5, 2024 · 1 comment · Fixed by #883
Assignees
@barmac
Labels
a11y bug Something isn't working good first issue Good for newcomers

Comments

@barmac
Copy link
Member

barmac commented Apr 5, 2024 •
edited by nikku
Loading

Describe the Bug

The table header is unreachable with a keyboard, so it requires mouse doubleclick to modify.

Steps to Reproduce

Try to tab to the input/output header.

Expected Behavior

Table header should be focussable and user should be able to open it. It can open automatically or via Enter.

Environment

Please complete the following information:

  • Browser: [e.g. IE 11, Chrome 69]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]

Child of https://github.com/bpmn-io/internal-docs/issues/909
@barmac barmac added bug Something isn't working ready Ready to be worked on a11y labels Apr 5, 2024
@nikku nikku added the good first issue Good for newcomers label Apr 10, 2024
@nikku nikku mentioned this issue May 24, 2024
Closed
@barmac
Copy link
Member Author

barmac commented Jun 13, 2024

I considered adding an edit button like we already have in the boxed expression, but it would hide the "move column" handler:

image

barmac added a commit that referenced this issue Jun 13, 2024
@barmac
feat: add edit input/output button
ba2a4bf 
The button is visually hidden unless focussed with keyboard.

Closes #845
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 13, 2024
@barmac barmac mentioned this issue Jun 13, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 13, 2024
barmac added a commit that referenced this issue Jun 14, 2024
@barmac
feat: add edit input/output button
cea3149 
The button is visually hidden unless focussed with keyboard.

Closes #845
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 14, 2024
This was referenced Jun 19, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
a11y bug Something isn't working good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add edit input/output button bpmn-io/dmn-js
2 participants
@nikku @barmac