Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drd/DrdUpdater): do not crop connections straight after reconnection #398

Merged
merged 2 commits into from
Apr 10, 2019
Merged

fix(drd/DrdUpdater): do not crop connections straight after reconnection #398

merged 2 commits into from
Apr 10, 2019

Conversation

barmac
Copy link
Member

@barmac barmac commented Apr 9, 2019

@ghost ghost assigned barmac Apr 9, 2019
@ghost ghost added the needs review Review pending label Apr 9, 2019
nikku
nikku reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also bump the diagram-js version used?

And can we make this a CHORE, not a FIX. We are not fixing an actual bug, rather we update to the new behavior in diagram-js.

@barmac
Copy link
Member Author

barmac commented Apr 10, 2019

Sure, I'll do this.

@barmac barmac force-pushed the do-not-crop-connection-on-reconnect branch 2 times, most recently from 9f21560 to 0cc77b2 Compare April 10, 2019 10:57
@barmac barmac force-pushed the do-not-crop-connection-on-reconnect branch from 0cc77b2 to d2a5eb4 Compare April 10, 2019 10:59
@barmac barmac changed the title fix(drd/DrdUpdater): do not crop connections straight after reconnection WIP fix(drd/DrdUpdater): do not crop connections straight after reconnection Apr 10, 2019
@barmac barmac changed the title WIP fix(drd/DrdUpdater): do not crop connections straight after reconnection fix(drd/DrdUpdater): do not crop connections straight after reconnection Apr 10, 2019
@barmac
Copy link
Member Author

barmac commented Apr 10, 2019

Done.

@merge-me merge-me bot merged commit 5475ede into master Apr 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the do-not-crop-connection-on-reconnect branch April 10, 2019 19:16
@ghost ghost removed the needs review Review pending label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees

@barmac barmac

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barmac @nikku