-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocompletion): support nested variables #34
Conversation
I will move this back to "In progress" as I found one requirement missing when working on Variable merging: we can merge types to "any", but not for lists. I will rework the PR to allow an entry to allow both List and Context entries for ambiguous definitions |
d268bcc addresses the It does not support all options, as Context and array need to have the same entries. Problem e.g.: "List | Context< foo: string >" will suggest I could not find a satisfactory variable schema that supports both. However, overlapping schemas should be avoided anyway and with linting on process level, this might not become a problem. I propose to go with the simple solution now and fix it when users notice it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marstamm walked me through it and I verified it works as expected. Approval from my side. ✅
This adds support for
pathExpression
suggestions, includingpathExpressions
with lists