Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocompletion): support nested variables #34

Merged
merged 7 commits into from
Dec 7, 2022

Conversation

marstamm
Copy link
Collaborator

This adds support for pathExpression suggestions, including pathExpressions with lists

Recording 2022-11-22 at 15 30 19

@marstamm marstamm requested a review from a team November 22, 2022 14:35
@marstamm marstamm self-assigned this Nov 22, 2022
@marstamm marstamm requested review from philippfromme and smbea and removed request for a team November 22, 2022 14:35
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 22, 2022
@marstamm
Copy link
Collaborator Author

marstamm commented Dec 1, 2022

I will move this back to "In progress" as I found one requirement missing when working on Variable merging: we can merge types to "any", but not for lists. I will rework the PR to allow an entry to allow both List and Context entries for ambiguous definitions

@marstamm marstamm added in progress Currently worked on and removed needs review Review pending labels Dec 1, 2022
@marstamm marstamm marked this pull request as draft December 1, 2022 08:18
@marstamm
Copy link
Collaborator Author

marstamm commented Dec 2, 2022

d268bcc addresses the list optional problem.

It does not support all options, as Context and array need to have the same entries. Problem e.g.: "List | Context< foo: string >" will suggest foo on input[0]., even though the List would not be of complex objects.

I could not find a satisfactory variable schema that supports both. However, overlapping schemas should be avoided anyway and with linting on process level, this might not become a problem. I propose to go with the simple solution now and fix it when users notice it

@marstamm marstamm marked this pull request as ready for review December 2, 2022 08:36
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 2, 2022
@marstamm marstamm requested a review from nikku December 7, 2022 08:49
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marstamm walked me through it and I verified it works as expected. Approval from my side. ✅

@philippfromme philippfromme merged commit 1147955 into main Dec 7, 2022
@philippfromme philippfromme deleted the list-and-path-expressions branch December 7, 2022 15:20
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants