Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL direction support via properties panel (part 1) #1212

Closed
wants to merge 19 commits into from

Conversation

okaeiz
Copy link

@okaeiz okaeiz commented Jun 16, 2024

Has worked on #1205

  • This PR adds a new form-js group named StyleGroup to the properties panel that is activated for the form component (default type).
  • This PR also adds a DirectionEntry to the newly-added StyleGroup which is a global option that sets the direction of the form components.
  • Within this PR, only the following components adhere to DirectionEntry:
    • Checkbox
    • Checkbox group
    • Button
    • Text Field (I will work on another entry for this component which can overwrite the DirectionEntry value)
  • If the direction is rtl, the font is changed to Vazirmatn which has been discussed before in Camunda main repository. The font change is only applied on the so-called form components.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ okaeiz
❌ root


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@okaeiz
Copy link
Author

okaeiz commented Jun 16, 2024

I made some changes before configuring my Git user; can we skip the CLA signature for root?

@Skaiir
Copy link
Contributor

Skaiir commented Jun 16, 2024

@okaeiz We can, but major thing right now is to clean up the PR, I'll review the code afterwards.

You might want to reset to bpmn-io:develop, and then cherry pick your changes into it. I see some duplicate commits, and also a tons of merge commits which we don't allow in PRs.

@Skaiir
Copy link
Contributor

Skaiir commented Jun 16, 2024

If the PR isn't yet in a finished state, we usually make use of the draft functionality of github :)

@okaeiz okaeiz deleted the branch bpmn-io:develop June 18, 2024 03:41
@okaeiz okaeiz closed this Jun 18, 2024
@okaeiz okaeiz deleted the develop branch June 18, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants