Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: input adorners for number and text fields #460

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Dec 12, 2022

Closes #420

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 12, 2022
Comment on lines 39 to 40
prefixAdorner,
suffixAdorner,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads a bit redundant. Should we have the schema like this?

{
  type: 'number',
  adorners: {
    prefix: '',
    suffix: ''
  }
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, as basically proposed by @christian-konrad

{
  type: 'number',
  display: {
    prefixAdorner: '',
    suffixAdorner: ''
  }
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now

{
  type: 'number',
  appearance: {
    prefixAdorner: '',
    suffixAdorner: ''
  }
}

@Skaiir Skaiir force-pushed the 420-adorners branch 2 times, most recently from 8f84519 to c94a762 Compare December 12, 2022 11:55
@Skaiir Skaiir marked this pull request as ready for review December 12, 2022 11:56
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 12, 2022
Closes #420

Co-Authored-By: Niklas Kiefer <niklas.kiefer@camunda.com>
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some more test coverage. Looks good to me, nice little improvement 👍

@pinussilvestrus pinussilvestrus merged commit a2bb504 into develop Dec 12, 2022
@pinussilvestrus pinussilvestrus deleted the 420-adorners branch December 12, 2022 15:24
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to add prefix and suffix appearance for form fields
2 participants