-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: input adorners for number and text fields #460
Conversation
prefixAdorner, | ||
suffixAdorner, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads a bit redundant. Should we have the schema like this?
{
type: 'number',
adorners: {
prefix: '',
suffix: ''
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, as basically proposed by @christian-konrad
{
type: 'number',
display: {
prefixAdorner: '',
suffixAdorner: ''
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now
{
type: 'number',
appearance: {
prefixAdorner: '',
suffixAdorner: ''
}
}
8f84519
to
c94a762
Compare
Closes #420 Co-Authored-By: Niklas Kiefer <niklas.kiefer@camunda.com>
c94a762
to
7efdcb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some more test coverage. Looks good to me, nice little improvement 👍
Closes #420