Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer): clean up errors for hidden fields #827

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

pinussilvestrus
Copy link
Contributor

Closes #825

I actually wonder whether this worked beforehand, as conditions never refer to form field IDs, but their respective key.

Seems like we had a lack of test coverage over here. Feel free to check @Skaiir!

@Skaiir
Copy link
Contributor

Skaiir commented Sep 29, 2023

My changes include:

Filtering of errors is done in the validation method directly. The error state is changed within it, it doesn't make sense to me that the error state should be any different (old bug, I've extended the test case to handle this too).
I've also made conditionChecker default to using a path, but also allowing it to have a specific path function. That way when we want to filter data on a basis other than the object's value path (such as id), we can specify the path function externally.

Copy link
Contributor Author

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Only one potential test case to add, feel free to merge as you like 👍

@pinussilvestrus pinussilvestrus merged commit 6b4240d into master Oct 5, 2023
11 of 13 checks passed
@pinussilvestrus pinussilvestrus deleted the 825-errors-hidden-fields branch October 5, 2023 07:56
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants