feat: allow async form providers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
smbea and
barmac
and removed request for
a team
marstamm
changed the title
marstamm
force-pushed
the
allow-async-resolvers
branch
from
a3cc8b2
to
eaa4b0c
Compare
nikku
reviewed
Nov 27, 2023
package.json
Outdated
| "bpmn-js": "^14.0.0" | ||
| "@bpmn-io/form-js": "^1.4.1", | ||
| "@bpmn-io/variable-resolver": "^1.2.0", | ||
| "bpmn-js": "^15.2.0" |
There was a problem hiding this comment.
Do we want to make form-js and bpmn-js peer dependencies here? I believe this is one of the places where this is granted.
In fact we don't want to use our own forms + bpmn-js, but resort on whatever is used as part of the stack, right?
There was a problem hiding this comment.
Agreed, I'll change it
There was a problem hiding this comment.
==> 7d56c04
I also marked variable-resolver as peer, since it does not make sense to have form resolving without variable completion
nikku
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/camunda/product-hub/issues/1792
closes #3