Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error thrown on trait introspection #46

Merged
merged 1 commit into from Dec 19, 2022
Merged

Improve error thrown on trait introspection #46

merged 1 commit into from Dec 19, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Dec 17, 2022 •
edited

Traits are not meant to be instantiated; their types can usually not be retrieved.

This PR ensures such miss-use is properly indicated to the user.

Closes #38

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 17, 2022
@nikku nikku requested a review from barmac December 17, 2022 20:07
@nikku nikku changed the title feat: improve error thrown on trait introspection Improve error thrown on trait introspection Dec 17, 2022
barmac
barmac approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that in this PR we block getting a type which purpose is to extend another type. This makes sense.

@fake-join fake-join bot merged commit 24b797f into master Dec 19, 2022
@fake-join fake-join bot deleted the trait-introspection-error branch December 19, 2022 09:11
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees

@nikku nikku

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in DescriptorBuilder for extension with redefines
2 participants
@nikku @barmac