fix(Moddle): replicate set/get API for createAny elements #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
marstamm
force-pushed
the
replicate-api-on-createAny
branch
from
12edafd
to
3fef9ed
Compare
barmac
requested changes
May 4, 2023
lib/moddle.js
Outdated
| return this[name]; | ||
| }, | ||
| set: function(name, value) { | ||
| this[name] = value; |
There was a problem hiding this comment.
This leads to prototype pollution:
~/workspace/bpmn-io/moddle replicate-api-on-createAny 7s
❯ node
Welcome to Node.js v18.12.1.
Type ".help" for more information.
> const Moddle = require('.')
undefined
> Moddle
{
Moddle: [Function: Moddle],
coerceType: [Function: coerceType],
isBuiltInType: [Function: isBuiltIn],
isSimpleType: [Function: isSimple],
parseNameNS: [Function: parseName]
}
> const model = new Moddle.Moddle([])
undefined
> const a = model.createAny('test', 'http://example.com')
undefined
> a.set('__proto__', { hacked() { console.log('hacked') } })
undefined
> a.hacked()
hacked
undefined
Cf. min-dash#set for mitigation: https://github.com/bpmn-io/min-dash/blob/master/lib/object.js#L40
We could also reuse min-dash method if we make sure name is string and not array.
There was a problem hiding this comment.
Good catch. Addressed with 118b5fd by using min-dash
bpmn-io-tasks
bot
added
in progress
nikku
reviewed
May 4, 2023
| set: function(name, value) { | ||
| this[name] = value; | ||
| set: function(key, value) { | ||
| set(this, [ key ], value); |
barmac
approved these changes
May 4, 2023
|
Thanks for the review, I'll take care of the patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to camunda/camunda-modeler#3589