Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two ellipses (circles) intersection #17

Closed
nblthree opened this issue Dec 6, 2020 · 2 comments · Fixed by #19
Closed

Two ellipses (circles) intersection #17

nblthree opened this issue Dec 6, 2020 · 2 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@nblthree
Copy link

nblthree commented Dec 6, 2020

Describe the Bug

Doesn't return the right result

Steps to Reproduce

use the following two paths

<path d="M2.6146209161795992e-14,73 A427,427 -90,0,0 -7.843862748538798e-14,927 A427,427 -90,1,0 2.6146209161795992e-14,73" stroke="black" stroke-width="10" fill="none"/>
<path d="M71.048,16.789855835444428 A439.5,439.5 0,0,1 928.6918008943089,15.63106872689174 A439.5,439.5 0,1,1 71.048,16.789855835444428" stroke="black" stroke-width="10" fill="none"/>

A codesandbox

https://codesandbox.io/s/youthful-banzai-nd88h?file=/src/index.js

Expected Behavior

return the right intersections

Environment

  • Host (Browser/Node version), if applicable: latest chrome, latest firefox
  • OS: Windows 10
  • Library version: 2.2.0
@nblthree nblthree added the bug Something isn't working label Dec 6, 2020
@nblthree nblthree changed the title Two ellipses intersection Two ellipses (circles) intersection Dec 6, 2020
@nikku
Copy link
Member

nikku commented Dec 7, 2020

Thanks for the comprehensive bug report. I'll have a look, but cannot promise a quick fix.

@pinussilvestrus pinussilvestrus added backlog Queued in backlog bug Something isn't working and removed bug Something isn't working labels Dec 9, 2020
@nblthree nblthree mentioned this issue Mar 2, 2021
Closed
@nikku nikku mentioned this issue Mar 15, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Mar 15, 2021
@nikku nikku closed this as completed in #19 Mar 15, 2021
nikku pushed a commit that referenced this issue Mar 15, 2021
@or
fix: correctly parse path strings with scientific notation (#19)
2a5d6e9 
The stray backslash prevented parsing of path strings that include
values with scientific notation, quietly claiming there was no
intersection.

Closes #18
Closes #17
nikku added a commit that referenced this issue Mar 15, 2021
@nikku
test: verify intersection of ellipsis
f79e3f3 
Related to #17
fake-join bot pushed a commit that referenced this issue Mar 15, 2021
@nikku @fake-join
test: verify intersection of ellipsis
7d83d00 
Related to #17
@nikku
Copy link
Member

nikku commented Mar 15, 2021

Released v2.2.1 with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in regex for scientific notation or/path-intersection
3 participants
@nikku @pinussilvestrus @nblthree