fix: use span instead of div inside buttons

HTML5 allows to pass only inline elements as button children. Cf. https://stackoverflow.com/questions/12982269/is-it-semantically-incorrect-to-put-a-div-or-span-inside-of-a-button/48383389
bpmn-io · Oct 22, 2021 · 350171b · 350171b
1 parent 819495a
commit 350171b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to [`@bpmn-io/properties-panel`](https://github.com/bpmn-io/
 
 ___Note:__ Yet to be released changes appear here._
 
+* `FIX`: use valid HTML in add/remove buttons ([#111](https://github.com/bpmn-io/properties-panel/pull/111))
 
 ## 0.5.1
 

diff --git a/src/components/ListGroup.js b/src/components/ListGroup.js
@@ -159,7 +159,7 @@ export default function ListGroup(props) {
                   <CreateIcon />
                   {
                     !hasItems ? (
-                      <div class="bio-properties-panel-add-entry-label">Create</div>
+                      <span class="bio-properties-panel-add-entry-label">Create</span>
                     )
                       : null
                   }

diff --git a/src/components/entries/List.js b/src/components/entries/List.js
@@ -113,7 +113,7 @@ export default function List(props) {
             <CreateIcon />
             {
               !hasItems ? (
-                <div class="bio-properties-panel-add-entry-label">Create</div>
+                <span class="bio-properties-panel-add-entry-label">Create</span>
               )
                 : null
             }