Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group tooltips are clipped when properties panel is scrollable (in firefox) #266

Closed
smbea opened this issue Jul 28, 2023 · 4 comments · Fixed by #268
Closed

Group tooltips are clipped when properties panel is scrollable (in firefox) #266

smbea opened this issue Jul 28, 2023 · 4 comments · Fixed by #268
Assignees
Labels
bug Something isn't working

Comments

@smbea
Copy link
Contributor

smbea commented Jul 28, 2023

Describe the Bug

The position:fixed acts like position:absolute in Firefox for group headers when the properties panel container becomes scrollable.

Screen.Recording.2023-07-28.at.13.33.15.mov

Steps to Reproduce

  1. open enough group header sections so that the properties panel becomes scrollable
  2. toggle a group header tooltip
  3. see that it appears hidden

Expected Behavior

Should behave the same as in Chrome: tooltips should appear

Environment

  • Host (Browser/Node version), if applicable: Firefox
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@smbea smbea added the bug Something isn't working label Jul 28, 2023
@smbea
Copy link
Contributor Author

smbea commented Jul 28, 2023

This only happens in group headers because of the position:sticky they have

@smbea smbea self-assigned this Jul 28, 2023
@smbea smbea added the ready Ready to be worked on label Jul 28, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jul 28, 2023
smbea added a commit that referenced this issue Jul 28, 2023
@Skaiir
Copy link
Contributor

Skaiir commented Jul 29, 2023

There seems to be some mentions of this in the Firefox dev issues and it seems they aren't planning on fixing it, so rendering it outside the group header is probably the only choice 👍

@smbea
Copy link
Contributor Author

smbea commented Jul 31, 2023

I have tried that in #268 and it works. The only issue is that is messes up the focus tree

@smbea
Copy link
Contributor Author

smbea commented Jul 31, 2023

After some discussion, we decided to fix the display issues right now and I will open a separate issue to address the focus since it may be that we need to programatically control it.

@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 31, 2023
smbea added a commit that referenced this issue Jul 31, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants