Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For the FEEL popup editor, allow feelPopupContainer to be a CSS selector #291

Closed
marstamm opened this issue Sep 25, 2023 · 0 comments · Fixed by #296
Closed

For the FEEL popup editor, allow feelPopupContainer to be a CSS selector #291

marstamm opened this issue Sep 25, 2023 · 0 comments · Fixed by #296
Assignees
@marstamm

Comments

@marstamm
Copy link
Contributor

What should we do?

Allow the config option config.propertiesPanel.feelPopupContainer to optionally be a CSS selector

Why should we do it?

This is in line with other places where we require a container, like the bpmn-js container or the feelTooltipContainer.
This is required because we might bootstrap the editor cached without the container present. In these cases, the container should be determined at render time (cf. camunda/camunda-modeler#3877 (comment))
@marstamm marstamm self-assigned this Sep 26, 2023
@marstamm marstamm added the ready Ready to be worked on label Sep 26, 2023
marstamm added a commit that referenced this issue Sep 29, 2023
@marstamm
feat(Popup): allow PopupContainer to be a CSS selector
d3cedb1 
closes #291
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Sep 29, 2023
@marstamm marstamm mentioned this issue Sep 29, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 29, 2023
@fake-join fake-join bot closed this as completed in #296 Sep 29, 2023
fake-join bot pushed a commit that referenced this issue Sep 29, 2023
@marstamm @fake-join
feat(Popup): allow PopupContainer to be a CSS selector
1c4bde9 
closes #291
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Popup): allow PopupContainer to be a CSS selector bpmn-io/properties-panel
1 participant
@marstamm