Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the FEEL popup editor icon #310

Closed
RomanKostka opened this issue Nov 8, 2023 · 0 comments · Fixed by #312
Closed

Change the FEEL popup editor icon #310

RomanKostka opened this issue Nov 8, 2023 · 0 comments · Fixed by #312
Assignees
@nikku
Labels
good first issue Good for newcomers

Comments

@RomanKostka
Copy link

What should we do?

We should change the FEEL popup editor icon to the 'popup' icon.
Popup icon:
image
image

Additional information:

Why should we do it?

The current icon ( 'launch icon' ) is being used to indicate an external Link.
Launch icon:
image

Therefore we should change the FEEL popup editor icon to the 'popup icon' which makes it clear what to expect.
Popup icon:
image
@smbea smbea added the ready Ready to be worked on label Nov 21, 2023
@nikku nikku added the good first issue Good for newcomers label Nov 24, 2023
nikku added a commit that referenced this issue Nov 30, 2023
@nikku
feat: use popup icon for FEEL editor
0637684 
Closes #310
nikku added a commit that referenced this issue Nov 30, 2023
@nikku
feat: use popup icon for FEEL editor
191face 
Closes #310
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Nov 30, 2023
@nikku nikku mentioned this issue Nov 30, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Nov 30, 2023
@nikku nikku closed this as completed in #312 Dec 1, 2023
nikku added a commit that referenced this issue Dec 1, 2023
@nikku
feat: use popup icon for FEEL editor
0f75dba 
Closes #310
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 1, 2023
nikku added a commit to camunda/camunda-bpmn-js that referenced this issue Dec 20, 2023
@nikku
deps: update to bpmn-js-properties-panel@5.7.0
2a42060 
Cf. https://github.com/bpmn-io/bpmn-js-properties-panel/blob/main/CHANGELOG.md#570

deps: update to @bpmn-io/properties-panel@3.15.0

  Cf. https://github.com/bpmn-io/properties-panel/blob/main/CHANGELOG.md#3140
  Cf. https://github.com/bpmn-io/properties-panel/blob/main/CHANGELOG.md#3150

feat: capitalize `Camunda Form` ([bpmn-io/bpmn-jsproperties-panel#1005](https://github.com/bpmn-io/bpmn-jsproperties-panel/issues/1005))
feat(feel-editor): improve FEEL popup editor icon ([bpmn-io/properties-panel#310](bpmn-io/properties-panel#310))
feat(feel-editor): add contextual keyword completion in FEEL editor
fix(feel-editor): correct parsing of nested lists
fix(feel-editor): correct parsing of incomplete QuantifiedExpression
fix(feel-editor): only allow legal Name start characters
fix: prevent error inside web component ([bpmn-io/properties-panel#313](bpmn-io/properties-panel#313))
nikku added a commit to camunda/camunda-bpmn-js that referenced this issue Dec 22, 2023
@nikku
deps: update to bpmn-js-properties-panel@5.7.0
bda47f8 
Cf. https://github.com/bpmn-io/bpmn-js-properties-panel/blob/main/CHANGELOG.md#570

deps: update to @bpmn-io/properties-panel@3.15.0

  Cf. https://github.com/bpmn-io/properties-panel/blob/main/CHANGELOG.md#3140
  Cf. https://github.com/bpmn-io/properties-panel/blob/main/CHANGELOG.md#3150

feat: capitalize `Camunda Form` ([bpmn-io/bpmn-jsproperties-panel#1005](https://github.com/bpmn-io/bpmn-jsproperties-panel/issues/1005))
feat(feel-editor): improve FEEL popup editor icon ([bpmn-io/properties-panel#310](bpmn-io/properties-panel#310))
feat(feel-editor): add contextual keyword completion in FEEL editor
fix(feel-editor): correct parsing of nested lists
fix(feel-editor): correct parsing of incomplete QuantifiedExpression
fix(feel-editor): only allow legal Name start characters
fix: prevent error inside web component ([bpmn-io/properties-panel#313](bpmn-io/properties-panel#313))
@philippfromme philippfromme mentioned this issue Jan 3, 2024
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use popup icon for FEEL editor bpmn-io/properties-panel
3 participants
@nikku @smbea @RomanKostka