Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button of popup editor overlaps text during editing #364

Closed
Skaiir opened this issue Jun 3, 2024 · 3 comments · Fixed by #368
Closed

Close button of popup editor overlaps text during editing #364

Skaiir opened this issue Jun 3, 2024 · 3 comments · Fixed by #368
Assignees
Labels
bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Jun 3, 2024

Describe the Bug

Currently, the close button is overlapping some of the feel text when editing. This causes

grafik

Steps to Reproduce

  1. Pop a feel expression out
  2. Enter a bunch of text into it
  3. See above picture

Expected Behavior

  1. There should not be a conflict between this button and the text display. Move the Close button to the top bar of the FEEL Popup Editor. The area below will be reserved only for editing and previewing FEEL expressions.
@Skaiir Skaiir added bug Something isn't working ready Ready to be worked on labels Jun 3, 2024
@Skaiir Skaiir self-assigned this Jun 3, 2024
@volodymyr-melnykc
Copy link

volodymyr-melnykc commented Jun 3, 2024

To solve this issue and improve overall visual alignment, move the Close button to the top bar of the FEEL Popup Editor. This will reserve the area below only for editing and previewing FEEL expressions.
The button to close the popup should be an icon button, and hovering it should show the tooltip "Close."

See in Figma: https://www.figma.com/design/0j9HfQf1xxbfandkOB16hM/FEEL-Popup-Editor?node-id=1-3747&t=1boCVVH8sQ3syzrl-1

FEEL Popup Editor

@volodymyr-melnykc volodymyr-melnykc changed the title Close button of popout editor overlaps text during editing Close button of popup editor overlaps text during editing Jun 3, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Jun 3, 2024

Should we consider using a dock icon instead? It might better convey the idea that the change is not destructive, what do you think?

@volodymyr-melnykc
Copy link

Agreed that a tooltip for the close button will indicate that changes are saved when closing, so this action is not destructive.

Skaiir added a commit that referenced this issue Jun 5, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 5, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 5, 2024
Skaiir added a commit that referenced this issue Jun 5, 2024
Skaiir added a commit that referenced this issue Jun 7, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants