-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close button of popup editor overlaps text during editing #364
Comments
To solve this issue and improve overall visual alignment, move the Close button to the top bar of the FEEL Popup Editor. This will reserve the area below only for editing and previewing FEEL expressions. See in Figma: https://www.figma.com/design/0j9HfQf1xxbfandkOB16hM/FEEL-Popup-Editor?node-id=1-3747&t=1boCVVH8sQ3syzrl-1 |
Should we consider using a dock icon instead? It might better convey the idea that the change is not destructive, what do you think? |
Agreed that a tooltip for the close button will indicate that changes are saved when closing, so this action is not destructive. |
Describe the Bug
Currently, the close button is overlapping some of the feel text when editing. This causes
Steps to Reproduce
Expected Behavior
The text was updated successfully, but these errors were encountered: