fix(list-item): auto-focus works for <select> elements

[philippfromme]

<select> elements can now be auto-focused.

---

Closes #100

[nikku]

Nica!

[nikku]

Very nice follow up to what could have been a UX hick-up otherwise 👏.

/CC @andreasgeier

[barmac]

Do we need any changes regarding https://github.com/bpmn-io/properties-panel/blob/main/src/components/entries/List.js#L156 ?

[philippfromme]

Do we need any changes regarding https://github.com/bpmn-io/properties-panel/blob/main/src/components/entries/List.js#L156 ?

Oh, I didn't know about that. So we have the same functionality in two places?

[nikku]

Oh, I didn't know about that. So we have the same functionality in two places?

If possible, shall move that into a single behavior (or hook).

[barmac]

Do we need any changes regarding https://github.com/bpmn-io/properties-panel/blob/main/src/components/entries/List.js#L156 ?

Oh, I didn't know about that. So we have the same functionality in two places?

We do, though the behaviour is a bit different.

In a group list, we require to provide an ID of the entry to be focused. So theoretically, this could be a second or third entry of the item. In a nested list, we are not able to tell the ID upfront. Because of that, if you enable the autofocus, it will always be activated on the first input in an item.

[pinussilvestrus]

Oh, I didn't know about that. So we have the same functionality in two places?

If possible, shall move that into a single behavior (or hook).

Maybe something we should consider when aligning the behaviors in general (if we want to): #96

/cc @MaxTru

[philippfromme]

Okay, I will fix it in both places for now. We'll tackle DRYing up that code in a later refactoring.

[philippfromme]

Done. @pinussilvestrus or @barmac can you have another look at this?

[barmac]

Still ✅ from me.