Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(List): insert to bottom given no compareFn #104

Merged
merged 1 commit into from
Oct 5, 2021
Merged

feat(List): insert to bottom given no compareFn #104

merged 1 commit into from
Oct 5, 2021

Conversation

MaxTru
Copy link
Contributor

@MaxTru MaxTru commented Oct 5, 2021

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 5, 2021
@MaxTru MaxTru mentioned this pull request Oct 5, 2021
Closed
13 tasks
@MaxTru MaxTru requested a review from barmac October 5, 2021 14:41
@MaxTru MaxTru marked this pull request as ready for review October 5, 2021 14:41
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 5, 2021
barmac
barmac approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat.

pinussilvestrus
pinussilvestrus approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pinussilvestrus pinussilvestrus merged commit 3326fd7 into main Oct 5, 2021
@pinussilvestrus pinussilvestrus deleted the insert-to-bottom branch October 5, 2021 15:53
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

@barmac barmac barmac approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaxTru @pinussilvestrus @barmac