Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(header): add documentation ref #141

Merged
merged 1 commit into from
Mar 28, 2022
Merged

feat(header): add documentation ref #141

merged 1 commit into from
Mar 28, 2022

Conversation

pinussilvestrus
Copy link
Contributor

Related to bpmn-io/bpmn-js-properties-panel#616

Script to try it out

npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#616-documentation-header -l "bpmn-io/properties-panel#documentation-links-header" -c "npm run start:cloud-templates"

image

@pinussilvestrus pinussilvestrus requested review from currandwyer, a team, Skaiir and smbea and removed request for a team March 28, 2022 08:56
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 28, 2022
@pinussilvestrus
Copy link
Contributor Author

@currandwyer feel free to give your feedback regarding the design of the documentation link in this PR 👍

@pinussilvestrus pinussilvestrus mentioned this pull request Mar 28, 2022
Merged
currandwyer
currandwyer approved these changes Mar 28, 2022
View reviewed changes
Copy link

@currandwyer currandwyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

smbea
smbea approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

@pinussilvestrus pinussilvestrus merged commit 01e8bfe into main Mar 28, 2022
@pinussilvestrus pinussilvestrus deleted the documentation-links-header branch March 28, 2022 12:53
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 28, 2022
This was referenced Mar 28, 2022
Merged
Merged
@philippfromme philippfromme mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@currandwyer currandwyer currandwyer approved these changes

@smbea smbea smbea approved these changes

@Skaiir Skaiir Awaiting requested review from Skaiir Skaiir was automatically assigned from bpmn-io/modeling-dev

Assignees

@pinussilvestrus pinussilvestrus

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pinussilvestrus @currandwyer @smbea