chore: use element as key for entries #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
pinussilvestrus
and removed request for
a team
|
Just to make sure, does this still work with the Linter (showing the errors in the Properties panel, although the inputs are not visible)? |
There was a problem hiding this comment.
I integration tested this one together with Linting in the Camunda Desktop Modeler, and everything seems to work as expected. 👍
I like the approach to have the entries unique per selected element. If we ever come up with cross-element components that share its state, we can reconsider this. This kind of entry would have to be a custom one currently anyway.
I'd be up for trying this out but wait for another ✅ as it is a pretty core change.
|
@pinussilvestrus Do you approve this? If so, please ✔️ 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to bpmn-io/bpmn-js-properties-panel#712
test it out using