Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FeelEditor): focus editor on container click #179

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix(FeelEditor): focus editor on container click #179

merged 1 commit into from
Sep 6, 2022

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented Sep 5, 2022 •
edited

@marstamm marstamm requested a review from a team September 5, 2022 08:52
@marstamm marstamm self-assigned this Sep 5, 2022
@marstamm marstamm requested review from philippfromme and barmac and removed request for a team September 5, 2022 08:52
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 5, 2022
@marstamm
Copy link
Contributor Author

marstamm commented Sep 5, 2022

Try it out using npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel -l bpmn-io/properties-panel#fix-feel-focus

smbea
smbea approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm!

@marstamm marstamm merged commit 2ed1536 into main Sep 6, 2022
@marstamm marstamm deleted the fix-feel-focus branch September 6, 2022 09:38
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbea smbea smbea approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@barmac barmac Awaiting requested review from barmac barmac was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marstamm @smbea