Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEEL): buffer focus events without offset #197

Merged
merged 3 commits into from
Nov 17, 2022
Merged

fix(FEEL): buffer focus events without offset #197

merged 3 commits into from
Nov 17, 2022

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented Nov 15, 2022 •
edited
Loading

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 15, 2022
@marstamm marstamm requested review from a team, philippfromme and smbea and removed request for a team November 15, 2022 12:52
@marstamm marstamm marked this pull request as ready for review November 15, 2022 12:52
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 15, 2022
@marstamm
Copy link
Contributor Author

Actually, I was to quick with this one. It does not scroll into view. Moving to draft again.

Recording 2022-11-15 at 13 57 04

@marstamm marstamm marked this pull request as draft November 15, 2022 12:58
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Nov 15, 2022
@marstamm marstamm mentioned this pull request Nov 15, 2022
Merged
@marstamm
Copy link
Contributor Author

Scrolling is fixed by bpmn-io/feel-editor#30

@marstamm marstamm marked this pull request as ready for review November 15, 2022 17:56
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 15, 2022
@marstamm
Copy link
Contributor Author

Ready for review now

philippfromme
philippfromme approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@marstamm marstamm merged commit f640aa6 into main Nov 17, 2022
@marstamm marstamm deleted the feel-error-focus branch November 17, 2022 08:53
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marstamm @philippfromme