Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple text component #94

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Simple text component #94

merged 1 commit into from
Sep 14, 2021

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Sep 7, 2021 •
edited
Loading

Adds a simple text component (without labels, descriptions, ...)

Required by bpmn-io/bpmn-properties-panel#100 (Inputs & Outputs Lists)

image

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 7, 2021
@pinussilvestrus pinussilvestrus mentioned this pull request Sep 7, 2021
Merged
@pinussilvestrus pinussilvestrus changed the title Simple text components Simple text component Sep 7, 2021
@pinussilvestrus pinussilvestrus force-pushed the 54-simple-text-component branch 2 times, most recently from 09f4d98 to 0c1119b Compare September 13, 2021 06:54
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pinussilvestrus
Copy link
Contributor Author

I decoupled the branch from the nested lists so that it can be reviewed independently. Ready for review though.

@pinussilvestrus pinussilvestrus marked this pull request as ready for review September 13, 2021 08:55
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 13, 2021
@pinussilvestrus pinussilvestrus requested review from a team, philippfromme, MaxTru and andreasgeier and removed request for a team September 13, 2021 08:55
@pinussilvestrus pinussilvestrus merged commit 9e19057 into main Sep 14, 2021
@pinussilvestrus pinussilvestrus deleted the 54-simple-text-component branch September 14, 2021 06:49
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxTru MaxTru MaxTru approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme

@andreasgeier andreasgeier Awaiting requested review from andreasgeier

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pinussilvestrus @CLAassistant @MaxTru