Allow to change just some options

bpolaszek · Jan 23, 2020 · 7640f59 · 7640f59
1 parent 4d396b3
commit 7640f59
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Shh.php b/src/Shh.php
@@ -116,8 +116,9 @@ public function decrypt(string $base64EncodedPayload): string
      * @param array       $config
      * @return array - [privateKey, publicKey]
      */
-    public static function generateKeyPair(?string $passphrase = null, array $config = self::DEFAULT_OPENSSL_GENERATION_CONFIGURATION): array
+    public static function generateKeyPair(?string $passphrase = null, array $config = []): array
     {
+        $config += self::DEFAULT_OPENSSL_GENERATION_CONFIGURATION;
         $resource = \openssl_pkey_new($config)
             or ShhException::throwFromLastOpenSSLError('Unable to open resource.');
 

diff --git a/tests/ShhTest.php b/tests/ShhTest.php
@@ -135,6 +135,15 @@ public function it_generates_a_valid_keypair()
         $this->assertEquals('foo', $decrypted);
     }
 
+    /**
+     * @test
+     */
+    public function i_can_change_generation_options()
+    {
+        $this->assertEquals(800, \strlen(Shh::generateKeyPair()[0]));
+        $this->assertEquals(182, \strlen(Shh::generateKeyPair(null, ['private_key_bits' => 512])[0]));
+    }
+
     /**
      * @test
      */